Update numeric slider values on updateSearch

[mikmart]

Fixes #1110.

library(shiny)
library(DT)

ui <- fluidPage(
  actionButton("set_search", "Set column search"),
  tags$hr(),
  DTOutput("iris")
)

server <- function(input, output, session) {
  output$iris <- renderDT(
    datatable(iris, filter = "top")
  )

  proxy <- dataTableProxy("iris")
  observeEvent(input$set_search, {
    updateSearch(proxy, keywords = list(columns = c("", "5.0 ... 6.0")))
  })
}

shinyApp(ui, server)

[CLAassistant]

All committers have signed the CLA.

[yihui]

Thank you very much!

[mikmart]

I changed the approach to use a custom event updatesearch so that each search field can handle updates from R as it wishes. This was to avoid the unnecessary searchColumn() call while also bypassing the input throttling for character columns.

Would you have another look @yihui? In particular I'm wondering if the custom event name should be namespaced somehow.

[yihui]

I thought for a while, and perhaps we can pass an extra parameter to the input event handler to decide whether to throttle the search. You can find jQuery's trigger() documentation here: https://api.jquery.com/trigger/ The idea is that our handler fun takes two arguments e (event) and immediate (whether to search immediately or throttle the search). immediate is false by default, and we set it to true in the updateSearch() method, e.g.,

$(td).find('input').first().val(v).trigger('input', [true]);

I feel that might be a little simpler than defining an updatesearch event for all types of inputs. Let me know if the idea is not clear to you. I can also tweak the PR by myself. Thanks!

[mikmart]

Yeah that makes sense. I can pivot to that approach.

[mikmart]

Ready for a review again @yihui.

[yihui]

Looks perfect now! I'll make a cosmetic change and merge soon. Thank you so much!