Add renderDT(outputArgs=), remove doc dependency on deprecated Shiny funcs #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…funcs We're transitioning toward removing shiny::dataTableOutput and shiny::renderDataTable and having them shim their DT equivalents.
yihui
approved these changes
Mar 12, 2024
|
Sounds good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're transitioning toward removing
shiny::dataTableOutputandshiny::renderDataTableand having them shim their DT equivalents. (see rstudio/shiny#3986)Neither the addition of
outputArgsnor the removal of the@inheritParamsare urgently needed, just thought I'd do this while I was thinking of it.