Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attached files in email are all named "Filename" because of a mislabeled function parameter inside mime.R #314

Closed
jpd527 opened this issue Oct 18, 2023 · 4 comments · Fixed by #316
Closed

Attached files in email are all named "Filename" because of a mislabeled function parameter inside mime.R #314

jpd527 opened this issue Oct 18, 2023 · 4 comments · Fixed by #316

Comments

@jpd527
Copy link

jpd527 commented Oct 18, 2023

0e1b1c7#r130328464

str = "Filename", needs to be changed to fieldname = "Filename", on line 104 of mime.R to fix the issue and properly label file attachments in the email.
@jpd527 jpd527 mentioned this issue Oct 18, 2023
Closed
@chuxinyuan
Copy link

same problem.

@mvellinger
Copy link

This is quite breaking, yes.

aalucaci added a commit to aalucaci/blastula that referenced this issue Nov 10, 2023
@aalucaci
fix Excel attachments (rstudio#314)
6784811
@aalucaci aalucaci mentioned this issue Nov 10, 2023
Merged
rich-iannone pushed a commit that referenced this issue Nov 11, 2023
@aalucaci
fix Excel attachments (#314) (#316)
5f60f40
@tylerlittlefield
Copy link

For anyone that needs a quick fix, this is working for me on ubuntu:

remotes::install_version("blastula", "0.3.3")

@b-rhodes
Copy link

b-rhodes commented Feb 1, 2024

Would this be worth releasing as 0.3.5? Seems like a pretty impactful issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix Excel attachments (#314) aalucaci/blastula
5 participants
@jpd527 @mvellinger @b-rhodes @chuxinyuan @tylerlittlefield