Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tooltip()/popover()'s connectCallback() method now handles multiple calls #1020

Merged
merged 2 commits into from
Mar 20, 2024
Merged

tooltip()/popover()'s connectCallback() method now handles multiple calls #1020

merged 2 commits into from
Mar 20, 2024

Conversation

cpsievert
Copy link
Collaborator

Closes #1019

@cpsievert cpsievert added this to the v0.7.0 milestone Mar 20, 2024
@cpsievert cpsievert marked this pull request as ready for review March 20, 2024 17:06
gadenbuie
gadenbuie approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cpsievert cpsievert merged commit 9f1b35a into main Mar 20, 2024
13 checks passed
@cpsievert cpsievert deleted the nav-insert-popover branch March 20, 2024 17:30
@gadenbuie gadenbuie mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadenbuie gadenbuie gadenbuie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Both tooltip and popover don't work when used with nav_insert
2 participants
@cpsievert @gadenbuie