fix(card): Report full screen state at <id>_full_screen
#1032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how cards report their full screen state. Now, given
users will need to use
input$my_card_full_screen
to react to the card's full screen state change.Previously, we were providing
input$my_card
with essentiallylist(full_screen = TRUE)
, which we chose intending to leave room for future state or event data reporting. However, any use ofinput$my_card
takes a reactive dependency on the entire data structure reported from the client. If we imagine that we've added another reported event type viainput$my_card
, changes in the new event type will causeinput$my_card$full_screen
to invalidate, even if the value doesn't change.I explored a range of other options and using the
<id>_full_screen
pattern seems to be the most straightforward and best option at this time.