Navlist vendor prefix #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trast() (i.e., _our_ source code)
cpsievert
added a commit
to rstudio/shinycoreci-apps
that referenced
this pull request
Jan 7, 2021
cpsievert
added a commit
to rstudio/shinycoreci-apps
that referenced
this pull request
Jan 7, 2021
wch
approved these changes
Jan 8, 2021
cpsievert
added a commit
to rstudio/shinycoreci-apps
that referenced
this pull request
Jan 8, 2021
* init dynamic-tabs-compat testing app * Focus app logic and tests on insert+remove+show+hide of tabs in navbarPage()+tabsetPanel()+navlistPanel() * Run tests with BS3 and BS4 * Approve corrected BS4 screenshots (with rstudio/bslib#214) * Remove show/hide from navbar controls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a shinytest specific issue found in rstudio/shinycoreci-apps#77
(Also cleans-up patch file from #213)