New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `popover()` API #702

Merged

cpsievert merged 43 commits into main from popovers

Jul 26, 2023

Collaborator

cpsievert commented Jul 20, 2023 •

edited

Loading

TODO:

~~Should popovers be styled similarly to the new card() styling refresh (Shiny preset: Card baseline styles #704)?~~
- Update: let's handle this during or after Shiny preset: Card baseline styles #704

Closes #708


          First stab at popover()

a3c98e9

cpsievert commented

View reviewed changes

srcts/src/components/_utilsTooltip.ts Outdated Show resolved Hide resolved

cpsievert commented

View reviewed changes

inst/bslib-scss/bslib.scss Outdated Show resolved Hide resolved

cpsievert added 3 commits

July 20, 2023 00:09


          devtools::document() (GitHub Actions)

d5a7b92


          yarn build (GitHub Actions)

deab36d


          Resave distributed files (GitHub Action)

fe48eb7

cpsievert changed the title ~~First stab at popover()~~ Add popover() API

cpsievert and others added 10 commits

July 20, 2023 12:01


          Fix tooltip() options

02d42d4


          Fix careful updating logic; sync-up tooltip/popover feature-set (i.e.…

ca9470a

…, avoid duplication of tooltip contents & hide popover when trigger is no longer visible)


          Better naming

fc50570


          Add a ShinyResizeObserver (for better resizing of output bindings tha…

05c1b03

…t appear in tooltip/popover


          yarn build (GitHub Actions)

9283c28


          Rd doc improvementsl update _pkgdown.yml

d5356c7


          devtools::document() (GitHub Actions)

53973ec


          Resave data (GitHub Action)

0a408cb


          Rd doc improvements; update _pkgdown.yml

82cc626


          Move popover-header css to js

045e2a1

cpsievert marked this pull request as ready for review

July 20, 2023 21:44

cpsievert requested a review from gadenbuie

July 20, 2023 21:44

cpsievert and others added 5 commits

July 20, 2023 21:48


          devtools::document() (GitHub Actions)

d24fc93


          yarn build (GitHub Actions)

b5d5a09


          Resave distributed files (GitHub Action)

d34a921


          Be more careful about the possibility of content/header not existing …

…(which will be the case when the popover/tooltip is shown


          yarn build (GitHub Actions)

7741c73

gadenbuie reviewed

View reviewed changes

srcts/src/components/tooltip.ts Outdated Show resolved Hide resolved

gadenbuie reviewed

View reviewed changes

srcts/src/components/_utils.ts Outdated Show resolved Hide resolved

srcts/src/components/popover.ts Outdated Show resolved Hide resolved

gadenbuie reviewed

View reviewed changes

R/popover.R Show resolved Hide resolved

gadenbuie reviewed

View reviewed changes

R/popover.R Outdated Show resolved Hide resolved

gadenbuie reviewed

View reviewed changes

R/tooltip.R Outdated Show resolved Hide resolved


          Better handling of NULL options

e0b278d

cpsievert and others added 3 commits

July 24, 2023 15:45


          Fixes for update_popover(). Also, simplify logic and improve styling …

6168a2c

…surrounding btn-close


          yarn build (GitHub Actions)

7ab9dd1


          Resave data (GitHub Action)

87dee80

gadenbuie reviewed

View reviewed changes

_pkgdown.yml Outdated Show resolved Hide resolved

srcts/src/components/_utilsTooltip.ts Outdated Show resolved Hide resolved

srcts/src/components/popover.ts Outdated Show resolved Hide resolved

R/tooltip.R Show resolved Hide resolved

srcts/src/components/popover.ts Outdated Show resolved Hide resolved

srcts/src/components/popover.ts Show resolved Hide resolved

srcts/src/components/popover.ts Show resolved Hide resolved

srcts/src/components/tooltip.ts Outdated Show resolved Hide resolved

srcts/src/components/tooltip.ts Show resolved Hide resolved

srcts/src/components/tooltip.ts Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

gadenbuie mentioned this pull request

Popovers/tooltips in dynamic UI #708

Closed

gadenbuie reviewed

View reviewed changes

srcts/src/components/tooltip.ts Show resolved Hide resolved

srcts/src/components/popover.ts Show resolved Hide resolved

cpsievert and others added 4 commits

July 25, 2023 10:24


          Close button should have type='button'

d839235


          Code review

bbeca7c


          devtools::document() (GitHub Actions)

5716ee6


          yarn build (GitHub Actions)

300a74c

gadenbuie reviewed

View reviewed changes

R/popover.R Show resolved Hide resolved

gadenbuie reviewed

View reviewed changes

R/tooltip.R Show resolved Hide resolved

gadenbuie reviewed

View reviewed changes

srcts/src/components/inputs.ts Outdated Show resolved Hide resolved

gadenbuie approved these changes

View reviewed changes

Member

gadenbuie left a comment

Looks great! 💁‍♂️ 🍿


          Remove file committed by mistake

f176b4f

cpsievert mentioned this pull request

Add 314 - Unit tests for bslib::tooltip() rstudio/shinycoreci#194

Merged

cpsievert and others added 8 commits

July 26, 2023 15:06


          Better support for hyperlinks/anchors

89f99f2


          Update aria-pressed in shown/hidden events (important when the show/h…

1743e69

…ide is deriving from Bootstrap's event listeners


          Simplify/improve close button styles

83d5e85


          Merge branch 'main' into popovers

a007e29


          devtools::document() (GitHub Actions)

cefd8aa


          yarn build (GitHub Actions)

89dac5c


          Update NEWS

2ad7b36


          Tweak NEWS wording

865b844

cpsievert merged commit aa6e043 into main

11 checks passed

cpsievert deleted the popovers branch

July 26, 2023 22:00

cpsievert mentioned this pull request

Add unit tests for bslib::popover() rstudio/shinycoreci#203

Merged

schloerke added a commit to posit-dev/py-shiny that referenced this pull request


          Implement popovers and rename toggle_tooltip

1db16d3

Implements rstudio/bslib#702 and rstudio/bslib#721

gadenbuie mentioned this pull request

feat: Add dark-mode toggle switch #787

Merged

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet