Glue message upgrade #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
R/check_code.R:37:1: style: Lines should not be more than 100 characters. #' @param glue_pipe A glue string that returns the final message displayed when a user uses a pipe, \code{$>$}
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
schloerke
requested changes
Aug 6, 2019
schloerke
approved these changes
Aug 6, 2019
Codecov Report
@@ Coverage Diff @@
## dev #57 +/- ##
==========================================
- Coverage 61.89% 61.74% -0.16%
==========================================
Files 19 20 +1
Lines 622 630 +8
==========================================
+ Hits 385 389 +4
- Misses 237 241 +4
Continue to review full report at Codecov.
|
chendaniely
added a commit
that referenced
this pull request
Aug 7, 2019
* Message creation changes in check_result (#48) * changes + tests to check_result messages * I think I covered all message cases for check_result * remove test_message_check_result.R * unit tests for checking messages [wip] * add default gradethis options to .onLoad * correct message changes + tests for check_result * uncomment incorrect tests and fix them * rename match/correct to .is_match/.is_correct * res returns a single bool using `all` and raises warning (#47) * make sure res returns a single bool using `all` * add reshape2, tibble, and tidyr to suggests section of DESCRPTION * user/solution into fxns and skip tests if no pkg * move common custom expect fxns to helper-expect.R * add a warning before calling all() when length(res) > * add documentation about == and identical * remove dependencies only from billboard test #47 (comment) * Glue message upgrade + tests (#57), doc+DESCRIPTION changes * upgrade glue_message ability (pair with barret) * upgrade glue message generation for check result/code * upgrade glue_message ability (pair with barret) * upgrade glue message generation for check result/code * fix R CMD check warnings * small doc changes + lint fixes * add \link to docs * add \code brackets * add \link * add \code brackets to docs * barret review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.