Enable remaining cols_* for gt_group objects #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @shannonhaughton for this PR! We'll get to reviewing it soon but since it is substantially larger than your last PR it'll likely take more time to get through it. |
|
@olivroy this looks okay to me other than some code formatting, which could be resolved in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this pr I have applied
apply_to_grpto the remaining cols_* functions to enable them for gt_group objectsNote:
The expect_indentical didn't like the nanoplot output - a problem with tidyselect. I've commented that out incase it gets fixed in future (in testthat or Waldo), and tested that function slightly differently.
Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.