Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update visual-tests-latex.R to show Quarto version #1808

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Jul 18, 2024

Seems like the visual tests are off to a great start! #1804 (comment). Let's add the Quarto version there as an extra layer of safety / reproducibility.

@rich-iannone
Copy link
Member

This is all really great and super essential for finding new rendering issues!

@rich-iannone
Copy link
Member

Just an idea, but do you think it's possible to re-purpose the HTML tests and use the embedpdf Quarto extension (example at: https://jmgirard.github.io/embedpdf/native.html, repo: https://github.com/jmgirard/embedpdf)?

This would involve making PDFs for each example and generating the Quarto website with the appropriate shortcodes. Seems like a fair amount of work (and there could be some issues along the way) but the payoff is that we get the full set of examples visualized as LaTeX/PDF outputs.

Let me know if you'd like me to take an initial stab at this, or, if the interest is there for you to rig something up. But first let me know if you think this is an overall good strategy.

@rich-iannone rich-iannone merged commit d13f54a into rstudio:master Jul 18, 2024
13 checks passed
@olivroy
Copy link
Collaborator Author

olivroy commented Jul 18, 2024

I think it could be a good idea. However, 1 pdf per example would have to be produced, which will probably take time to do. Maybe not generating them via Quarto would be best in this case, to avoid too many computations.

I agree something more thorough should be done. However, I am not sure I am willing to invest a lot of time on that. I'd like to remain more focused on understanding where to make changes when bugs occur, (i.e. at init, build or render stage), improve the general documentation (#1675), and make sure no regressions are created (by adding tests and refactoring some).

But for LaTeX output, I am very impressed by Ken's recent improvements! Let's hope he continues doing integration testing :)

@rich-iannone
Copy link
Member

Oh yeah, I didn’t consider that the volume of examples could make PDF generation all very slow. Let’s keep adding to the system already in place. Thanks for getting that implemented btw!

Agreed that Ken does excellent work!

@olivroy olivroy deleted the patch-4 branch July 18, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants