Use webshot2 when generating image files with gtsave()#985
Merged
rich-iannone merged 3 commits intomasterfrom Jul 7, 2022
Merged
Use webshot2 when generating image files with gtsave()#985rich-iannone merged 3 commits intomasterfrom
gtsave()#985rich-iannone merged 3 commits intomasterfrom
Conversation
rich-iannone
changed the title
gtsave()gtsave()
cscheid
approved these changes
Jul 7, 2022
Member
cscheid
left a comment
cscheid
left a comment
There was a problem hiding this comment.
Assuming tests pass, this is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the image-generating implementation of
gtsave()when specifying a PNG or PDF. Here, webshot2 will be used instead of webshot and this will provide higher-fidelity images (due to better rendering with headless Chrome compared to PhantomJS). This change also allows for customization of theselectoroption during invocation of thewebshot2::webshot()function (defaulting to"table", which is the same as previously).Fixes: #621
Fixes: #885