-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public-facing readmes #1
Conversation
There are at present quite a few unpublic patterns used to get the rstudio-workbench chart working in production environments that have never been documented, so this adds some of that documentation here so our chart users can understand what needs to be done to be successful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Just a few thoughts
We have a few outlets for getting support with our projects: | ||
|
||
- Bugs or feature requests should be opened in an [issue](https://github.com/rstudio/helm/issues/new/choose). | ||
- Professional support for our Helm charts can be obtained by emailing support@rstudio.com. Please note that email support is limited to our professional products customers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdeitte do we have preferred wording here? Should we highlight that "Professional support for our products" is what is supported (versus the helm charts)? I know you did a bunch of work w/ the wording on support for the containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think we should use similar wording to what we have in docker, since that was run by Amanda/etc. At least until we've done more here. Something similar to https://github.com/rstudio/rstudio-docker-products#rstudio-pro-products-docker-images
Co-authored-by: Cole Arendt <cole@rstudio.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @colearendt mentioned, the README for RSW comes from a template. Maybe you should remove that file from this repo and open a PR for that template in rstudio/sol-eng-helm instead? Then we can copy that over when we port the RSW chart to this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CONTRIBUTING and README changes look great.
@jonyoder I wanted this to be a complete doc focused PR, so I went ahead and added the necessary template files into this PR. When we copy over the rest of the repo, we can leave those out. |
@colearendt Everything should be addressed and ready for re-review aside from the open question to @bdeitte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm fine if we want to merge and then we can update the support wording later if needed
Oh @kfeinauer I think we need to bump the RSPM chart version ( |
Associated with https://github.com/rstudio/sol-eng-helm/issues/64.
This is a first attempt at the main README and the
rstudio-workbench
README. Followup PRs will be done for the other charts.