Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public-facing readmes #1

Merged
merged 12 commits into from
Aug 4, 2021
Merged

Add public-facing readmes #1

merged 12 commits into from
Aug 4, 2021

Conversation

kfeinauer
Copy link
Contributor

@kfeinauer kfeinauer commented Aug 3, 2021

Associated with https://github.com/rstudio/sol-eng-helm/issues/64.

This is a first attempt at the main README and the rstudio-workbench README. Followup PRs will be done for the other charts.

There are at present quite a few unpublic patterns used to get
the rstudio-workbench chart working in production environments
that have never been documented, so this adds some of that documentation
here so our chart users can understand what needs to be done to be
successful.
Copy link
Contributor

@colearendt colearendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Just a few thoughts

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
We have a few outlets for getting support with our projects:

- Bugs or feature requests should be opened in an [issue](https://github.com/rstudio/helm/issues/new/choose).
- Professional support for our Helm charts can be obtained by emailing support@rstudio.com. Please note that email support is limited to our professional products customers.
Copy link
Contributor

@colearendt colearendt Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdeitte do we have preferred wording here? Should we highlight that "Professional support for our products" is what is supported (versus the helm charts)? I know you did a bunch of work w/ the wording on support for the containers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should use similar wording to what we have in docker, since that was run by Amanda/etc. At least until we've done more here. Something similar to https://github.com/rstudio/rstudio-docker-products#rstudio-pro-products-docker-images

charts/rstudio-workbench/README.md Show resolved Hide resolved
Co-authored-by: Cole Arendt <cole@rstudio.com>
Copy link
Collaborator

@jonyoder jonyoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @colearendt mentioned, the README for RSW comes from a template. Maybe you should remove that file from this repo and open a PR for that template in rstudio/sol-eng-helm instead? Then we can copy that over when we port the RSW chart to this repo.

Copy link
Collaborator

@jonyoder jonyoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CONTRIBUTING and README changes look great.

@kfeinauer
Copy link
Contributor Author

@jonyoder I wanted this to be a complete doc focused PR, so I went ahead and added the necessary template files into this PR. When we copy over the rest of the repo, we can leave those out.

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2021

CLA assistant check
All committers have signed the CLA.

@kfeinauer
Copy link
Contributor Author

@colearendt Everything should be addressed and ready for re-review aside from the open question to @bdeitte

Copy link
Contributor

@colearendt colearendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm fine if we want to merge and then we can update the support wording later if needed

@colearendt
Copy link
Contributor

Oh @kfeinauer I think we need to bump the RSPM chart version (rc02) - hence the failure

@kfeinauer kfeinauer merged commit eb606f7 into main Aug 4, 2021
@kfeinauer kfeinauer deleted the public-readmes branch August 4, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants