Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip_on_ci as with travis #638

Merged
merged 6 commits into from
Aug 13, 2021
Merged

skip_on_ci as with travis #638

merged 6 commits into from
Aug 13, 2021

Conversation

aronatkins
Copy link
Contributor

No description provided.

@aronatkins
Copy link
Contributor Author

A run of this branch against rhub passes, but in GHA, we're seeing

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure (test-dependencies.R:58:3): dependencies are discovered in inline R code ──
"emo" %in% packrat:::fileDependencies(emojiRmd) is not TRUE

`actual`:   FALSE
`expected`: TRUE 
── Failure (test-rmarkdown.R:22:3): We can discover dependencies with an evaluate hook ──
`deps` not equal to c("abc", "def", "ghi", "jkl").
target is NULL, current is character

@aronatkins
Copy link
Contributor Author

After adding pandoc to the GHA workflow, CI is passing. Also added multiple R versions, as it was unclear at first if the problems were with a version of R different than my development environment.

@aronatkins aronatkins merged commit d459d1c into rstudio:master Aug 13, 2021
@aronatkins aronatkins deleted the aron-ci branch August 13, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant