Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRC output format #43

Merged
merged 16 commits into from
Jan 2, 2019
Merged

CRC output format #43

merged 16 commits into from
Jan 2, 2019

Conversation

RLesur
Copy link
Collaborator

@RLesur RLesur commented Jan 2, 2019

Here's a first draft of the pagedown::book_crc() output format.
I'm sure there is many room for improvement: I reached the point where some external eyes are needed to find the features I missed.
In order to review the PR, here's a demo pdf file of your bookdown book: book_crc.pdf.
Since I'm on Linux, there is no hyphenation 😞.

@RLesur RLesur requested a review from yihui January 2, 2019 01:27
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! I'll just merge it, and we can certainly keep improving it in the future. Thanks!

@yihui yihui merged commit 6a91829 into rstudio:master Jan 2, 2019
@RLesur RLesur deleted the book_crc branch January 2, 2019 15:37
yihui added a commit that referenced this pull request Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants