-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes the httpuv connection: close workaround #318
Removes the httpuv connection: close workaround #318
Conversation
This has been fixed since at least httpuv version 1.4.0.
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
========================================
- Coverage 90.01% 90% -0.01%
========================================
Files 25 25
Lines 1142 1141 -1
========================================
- Hits 1028 1027 -1
Misses 114 114
Continue to review full report at Codecov.
|
Looks good to me. |
There's one more file in the commit you referenced: 4901c5e#diff-68678c8c847a2f72255e66a25514f0abR34 should we also update that one? |
@atheriel Thank you for the change! Could you please sign the CLA for when I merge the PR next week? Link: https://cla-assistant.io/trestletech/plumber?pullRequest=318 |
@schloerke Ah, I didn't realize I'd need to sign for this change, since I did not contribute any copyrightable material or code. It should show as signed now. |
* master: atheriel - remove connection close workaround (rstudio#318, rstudio#332)
* master: atheriel - remove connection close workaround (rstudio#318, rstudio#332)
This removes the workaround introduced in 4901c5e to avoid rstudio/httpuv#49, which has been fixed (in my estimation) since at least
httpuv
1.4.0.I've tentatively confirmed that environments are no longer shared between connections even when they are
keep-alive
by using the original integration test added in the referenced commit.As a nice bonus, this improves
plumber
's baseline latency by about 10% on my machine.