Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uft8 source file support #328

Merged
merged 25 commits into from
Nov 6, 2018
Merged

uft8 source file support #328

merged 25 commits into from
Nov 6, 2018

Commits on Oct 12, 2018

  1. The source files used in plumber must use the UTF-8 encoding if they … 

    …contain

non-ASCII characters
    @shrektan
    shrektan committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    1b19e3a View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2018

  1. comments

    @schloerke
    schloerke committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    0b82e79 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into add-param-encoding

    @schloerke
    schloerke committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    6c8908f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'add-param-encoding' of https://github.com/shrektan/plumber 

     into shrektan-add-param-encoding
    @schloerke
    schloerke committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    5d60c8a View commit details
    Browse the repository at this point in the history

  4. display appveyor local

    @schloerke
    schloerke committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    8578fb0 View commit details
    Browse the repository at this point in the history

  5. try in install script

    @schloerke
    schloerke committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    139f4fd View commit details
    Browse the repository at this point in the history

  6. chinese only

    @schloerke
    schloerke committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    d3d1326 View commit details
    Browse the repository at this point in the history

  7. top level scripts only

    @schloerke
    schloerke committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    e13c0a4 View commit details
    Browse the repository at this point in the history

  8. no cache

    @schloerke
    schloerke committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    98cda72 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2018

  1. use testthat::test_path when providing relative test files

    @schloerke
    schloerke committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    89b85f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2018

  1. add sourceUTF8 and helper functions from shiny 

    This stems from wanting to read utf8 files on a non utf8 locale.  On windows, the locale is set to the system default which typically does not support utf8 out of the box.

sourceUTF8 functions are adopted form the rstudio/shiny repo in an effort to use code that has already be validated to work.

The ending finding is that `source(file, encoding="UTF-8")` does not work as expected and instead should use `eval(parse(file, encoding = "UTF-8"))`
    @schloerke
    schloerke committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    b9014fc View commit details
    Browse the repository at this point in the history

  2. remove appveyor file as locale / utf8 can be tested on travis

    @schloerke
    schloerke committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    509562b View commit details
    Browse the repository at this point in the history

  3. add second PR to news item

    @schloerke
    schloerke committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    12b0d45 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2018

  1. add note for why sourcing is done

    @schloerke
    schloerke committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    c84d5ec View commit details
    Browse the repository at this point in the history

  2. add note about keeping the source location when parsing

    @schloerke
    schloerke committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    1026715 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. merged master

    @schloerke
    schloerke committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    fb41fa1 View commit details
    Browse the repository at this point in the history

  2. Evalauate all file expression blocks only once, not once or twice 

    Fixes tests made in rstudio#331
    @schloerke
    schloerke committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    cde0d3d View commit details
    Browse the repository at this point in the history

  3. activateBlock -> evaluateBlock

    @schloerke
    schloerke committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    aa2ed73 View commit details
    Browse the repository at this point in the history

  4. add comments about LC_ALL and use charToRaw to test UTF-8 strings

    @schloerke
    schloerke committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    9a3a40f View commit details
    Browse the repository at this point in the history

  5. minimize travis crand and github pkg downloads

    @schloerke
    schloerke committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    503bd82 View commit details
    Browse the repository at this point in the history

  6. remove travis comments

    @schloerke
    schloerke committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    8fba37f View commit details
    Browse the repository at this point in the history

  7. added news item about sourcing code only once

    @schloerke
    schloerke committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    370d17a View commit details
    Browse the repository at this point in the history

  8. bold **must use**

    @schloerke
    schloerke committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    d8d0dd0 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. add default appveyor

    @schloerke
    schloerke committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    f79b685 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into shrektan-add-param-encoding 

    * master:
  atheriel - remove connection close workaround (rstudio#318, rstudio#332)
    @schloerke
    schloerke committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    b1fb950 View commit details
    Browse the repository at this point in the history