-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Swagger Spec to OpenAPI v3 #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entually will be delivered via CDN.
helps to know how it will be formatted exactly
not necessary if we are switching to using lists and not data.frames
…to then extract information
Fixes #322 Fixes #323 See swagger-api/swagger-js#268 Thank you @Hong-Revo for a recursive blueprint in #323
jcheng5
approved these changes
Jan 3, 2019
Swagger v3 params
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 88.87% 87.78% -1.09%
==========================================
Files 27 27
Lines 1177 1195 +18
==========================================
+ Hits 1046 1049 +3
- Misses 131 146 +15
Continue to review full report at Codecov.
|
schloerke
changed the title
Update Swagger v1 to OpenAPI v3
Revamp Swagger Spec to OpenAPI v3
Jan 11, 2019
schloerke
added a commit
that referenced
this pull request
Jan 11, 2019
* master: Revamp Swagger Spec to OpenAPI v3 (#365)
schloerke
added a commit
that referenced
this pull request
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non backwards compatible change that will not effect 95% of users as swagger is typically programmatically generated. This will only effect users with custom hacks... but they should be happy with the function hook to additions to the swagger file information.
Features
openapi.json
topr
objectspr$run(swagger = MY_FUNC)
to allow for users to upgrade the swagger spec that is returned to./swagger.json
/./openapi.json
swagger-cli
to validate openapi v3 spec on mac / non cran computers only that have the swagger-cli pkg installed.swagger
R pkg to reduceplumber
package size and allow for updates to the Swagger UI faster thanplumber
releasesRemaining
swagger_spec()
and support major Swagger UI versions w/ download script swagger#7 - talk to Javierpr$run()
- (made issue)@blairj09