-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sodium instead of PKI #404
Conversation
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
==========================================
+ Coverage 89.3% 89.84% +0.54%
==========================================
Files 29 29
Lines 1449 1527 +78
==========================================
+ Hits 1294 1372 +78
Misses 155 155
Continue to review full report at Codecov.
|
* wording * add examples of using keyring and local file storage * link to keyring website * no default value for key * stop, don't warn if key is missing * do not allow for raw keys * if non 64-len or non-hex digit chars given, warn * use charToRaw over serialize
Oh, very important: when actually setting the session cookie, we must use |
Other than those wording tweaks, LGTM! |
Fixes #242