Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up print method #565

Merged
merged 8 commits into from
Jun 26, 2020
Merged

Clean up print method #565

merged 8 commits into from
Jun 26, 2020

Conversation

schloerke
Copy link
Collaborator

Fixes #564

Also removes bad partial arg matching warnings.

PR task list:

  • [NA] Update NEWS
  • Add tests
  • [NA] Update documentation with devtools::document()

@schloerke schloerke added this to the v0.5.0 - Next CRAN release milestone Jun 24, 2020
@schloerke schloerke self-assigned this Jun 24, 2020
@schloerke schloerke requested a review from cpsievert June 24, 2020 16:09
@cpsievert cpsievert self-requested a review June 25, 2020 20:38
@schloerke schloerke merged commit 300e702 into master Jun 26, 2020
@schloerke schloerke deleted the print_mount branch June 26, 2020 16:56
schloerke added a commit that referenced this pull request Jun 26, 2020
@schloerke
Merge branch 'master' into pkgdown
263fabb 
* master:
  Add router modifier tag support (`#' @plumber`) (#568)
  Clean up print method (#565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Print pr when subrouter mounted on root
2 participants
@schloerke @cpsievert