Register UI interfaces and remove non-essential $run() arguments #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge remote-tracking branch 'upstream/master' into interface_mount # Conflicts: # R/plumber.R # man/plumber.Rd
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Merge remote-tracking branch 'upstream/master' into interface_mount # Conflicts: # DESCRIPTION # R/plumber.R # man/plumber.Rd
Merge remote-tracking branch 'upstream/master' into interface_mount # Conflicts: # NEWS.md # R/plumber-options.R # man/options_plumber.Rd # man/plumber-package.Rd
Merge remote-tracking branch 'upstream/master' into interface_mount # Conflicts: # NEWS.md
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
As you wish. I left it TRUE so that It would pick up the first UI in the list from `.globals$UIs$mount[TRUE]`. Tried to have as much decoupling from the actual UI name as possible. Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
cpsievert
reviewed
Jul 30, 2020
cpsievert
reviewed
Jul 30, 2020
cpsievert
reviewed
Jul 30, 2020
cpsievert
reviewed
Jul 30, 2020
cpsievert
reviewed
Jul 30, 2020
cpsievert
reviewed
Jul 30, 2020
cpsievert
reviewed
Jul 30, 2020
cpsievert
approved these changes
Jul 30, 2020
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
2 tasks
|
… Static paths starting at `/`
…$default_serializer`
|
Squash Merging this PR on a Friday afternoon. Need to get it into people hands for them to make noise. 😉 |
schloerke
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #562
Includes all of #562 . Made a new PR to add some final code changes that I did not explain well.
PR task list:
devtools::document()