Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plumber.debug option #639

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Remove plumber.debug option #639

merged 3 commits into from
Aug 12, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 10, 2020 •
edited
Loading

Fixes #622

Removes options_plumber(debug) as the value being set could never be used.

PR task list:

  • [NA] Update NEWS
  • Update tests
  • Update documentation with devtools::document()

@schloerke schloerke added this to the v1.0.0 - Next CRAN release milestone Aug 10, 2020
@cpsievert cpsievert self-requested a review August 10, 2020 19:15
cpsievert
cpsievert requested changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of plumber.debug option completely

@schloerke schloerke changed the title Do not allow for plumber.debug to be set with options_plumber() Remove plumber.debug option Aug 12, 2020
@schloerke schloerke merged commit 328f3a1 into master Aug 12, 2020
@schloerke schloerke deleted the debug_location branch August 12, 2020 15:28
schloerke added a commit that referenced this pull request Aug 12, 2020
@schloerke
Merge branch 'master' into all_params_are_arrays
f973d81 
* master:
  Fix legacy Dockerfile example argument (#648)
  Remove `plumber.debug` option (#639)
  Added longer gpg key 51716619E084DAB9 to avoid collisions (#645)
  Added trimws so that ^analogsea regex works in checkAnalogSea (#643)
  Add support for Cookie SameSite attribute (#641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Debug info is stored in multiple places
2 participants
@schloerke @cpsievert