Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plumber.debug option #639

Merged
merged 3 commits into from Aug 12, 2020
Merged

Remove plumber.debug option #639

merged 3 commits into from Aug 12, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 10, 2020

Fixes #622

Removes options_plumber(debug) as the value being set could never be used.

PR task list:

  • [NA] Update NEWS
  • Update tests
  • Update documentation with devtools::document()

@schloerke schloerke added this to the v1.0.0 - Next CRAN release milestone Aug 10, 2020
@cpsievert cpsievert self-requested a review Aug 10, 2020
Copy link
Contributor

@cpsievert cpsievert left a comment

Get rid of plumber.debug option completely

@schloerke schloerke requested a review from cpsievert Aug 11, 2020
@schloerke schloerke changed the title Do not allow for plumber.debug to be set with options_plumber() Remove plumber.debug option Aug 12, 2020
@schloerke schloerke merged commit 328f3a1 into master Aug 12, 2020
1 check passed
@schloerke schloerke deleted the debug_location branch Aug 12, 2020
schloerke added a commit that referenced this pull request Aug 12, 2020
* master:
  Fix legacy Dockerfile example argument (#648)
  Remove `plumber.debug` option (#639)
  Added longer gpg key 51716619E084DAB9 to avoid collisions (#645)
  Added trimws so that ^analogsea regex works in checkAnalogSea (#643)
  Add support for Cookie SameSite attribute (#641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug info is stored in multiple places
2 participants