Provide arg names to all PlumberEndpoint variables in pr$handle()

DESCRIPTION

@@ -2,7 +2,7 @@ Encoding: UTF-8
 Package: plumber
 Type: Package
 Title: An API Generator for R
-Version: 1.0.0
+Version: 1.0.0.9999
 Roxygen: list(markdown = TRUE)
 Authors@R: c(
   person("Barret", "Schloerke", role = c("cre", "aut"), email = "barret@rstudio.com"),

NEWS.md

@@ -1,3 +1,10 @@
+plumber 1.0.0.9999 Development version
+--------------------------------------------------------------------------------
+
+### Bug fixes
+
+* When calling `Plumber$handle()` and defining a new `PlumberEndpoint`, `...` will be checked for invalid names #677  
+
 plumber 1.0.0
 --------------------------------------------------------------------------------
 

R/plumber.R

@@ -332,7 +332,7 @@ Plumber <- R6Class(
     #' @param serializer a serializer function.
     #' @param parsers a named list of parsers.
     #' @param endpoint a `PlumberEndpoint` object.
-    #' @param ... additional arguments for `PlumberEndpoint` creation
+    #' @param ... additional arguments for [PlumberEndpoint] `new` method (namely `lines`, `params`, `comments`, `responses` and `tags`. Excludes `envir`).
     #' @examples
     #' \dontrun{
     #' pr <- pr()
@@ -342,7 +342,7 @@ Plumber <- R6Class(
     #' }
     handle = function(methods, path, handler, preempt, serializer, parsers, endpoint, ...) {
       epdef <- !missing(methods) || !missing(path) || !missing(handler) || !missing(serializer) || !missing(parsers)
-      if (!missing(endpoint) && epdef){
+      if (!missing(endpoint) && epdef) {
         stop("You must provide either the components for an endpoint (handler and serializer) OR provide the endpoint yourself. You cannot do both.")
       }
 
@@ -353,8 +353,18 @@ Plumber <- R6Class(
         if (missing(parsers)) {
           parsers <- private$parsers
         }
+        forbid <- c("verbs", "expr", "envir")
+        forbid_check <- forbid %in% names(list(...))
+        if (any(forbid_check)) {
+          stop(paste0("`", forbid[forbid_check], "`", collapse = ", "), " can not be supplied to `pr$handle()` method.")
+        }
 
-        endpoint <- PlumberEndpoint$new(methods, path, handler, private$envir, serializer, parsers, ...)
+        endpoint <- PlumberEndpoint$new(verbs = methods,
+                                        path = path,
+                                        expr = handler,
+                                        envir = private$envir,
+                                        serializer = serializer,
+                                        parsers = parsers, ...)
       }
       private$addEndpointInternal(endpoint, preempt)
     },

tests/testthat/test-plumber.R

@@ -523,3 +523,13 @@ test_that("routes that don't start with a slash are prepended with a slash", {
   expect_equal(length(pr$endpoints[[1]]), 1L)
   expect_equal(pr$endpoints[[1]][[1]]$path, "/nested/path/here")
 })
+
+test_that("handle method rejects forbidden arguments", {
+  pr <- pr()
+  expect_error(pr$handle("GET", "nested/path/here", function(){}, envir = new.env()),
+               "can not be supplied to", )
+  expect_error(pr$handle("GET", "nested/path/here", function(){}, verbs = "GET"),
+               "can not be supplied to")
+  expect_error(pr$handle("GET", "nested/path/here", function(){}, expr = function(){}),
+               "can not be supplied to")
+})