Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for rendering reports in Quarto #520

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

yjunechoe
Copy link
Collaborator

@yjunechoe yjunechoe commented Feb 28, 2024

All {gt} reports (agent, informant, multiagent) are now post-processed with gt::fmt(fns = identity) to prevent treating them as data tables in Quarto. More formally put, reports rendered in Quarto no longer come with any <div data-qmd="...">. I've also added a manual test tests/manual_tests/test-quarto-render.R that checks for this.

This PR also fixes an issue with <code> in reports inheriting purple color from the Quarto theme.

Reprex from #518

image

Fixes: #518

@rich-iannone rich-iannone self-requested a review February 28, 2024 19:08
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit 6d5edc4 into rstudio:main Feb 28, 2024
13 checks passed
@yjunechoe yjunechoe deleted the quarto-render-workaround branch February 28, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarto render --to html makes some html tags visible in the validation report
2 participants