Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install of package from unknown source fails with renv 0.2.0-49 and later #41

Closed
asodja opened this issue Apr 3, 2019 · 7 comments
Closed

Comments

@asodja
Copy link

asodja commented Apr 3, 2019

When restoring package from unknown source with renv.verbose=TRUE there is error with following message:
Message:
Error in renv_verbose() && renv_pretty_print_records(unknown, "The following package(s) were installed from an unknown source:", : invalid 'y' type in 'x && y'.

Bug was probably introduced with commit:
327eabf

In function renv_restore_preflight_unknown_source:
renv_verbose() && renv_pretty_print(...)
probably should be:
if (renv_verbose()) { renv_pretty_print(...) }

There might be similar issue in function renv_restore_preflight_permissions.

@kevinushey
Copy link
Collaborator

Thanks! You're correct; I'll fix that.

@kevinushey
Copy link
Collaborator

Just fixed it up -- please try running renv::upgrade() to get the fixed-up copy of renv in your project.

@asodja
Copy link
Author

asodja commented Apr 3, 2019

Thanks, this fix works. Although for renv::upgrade() I get for renv 0.2.0-47 and later:

> renv::upgrade() Error in map[[json]] : subscript out of bounds
It works fine with 0.2.0-46.

@kevinushey
Copy link
Collaborator

Thanks -- I'll try to investigate.

@kevinushey
Copy link
Collaborator

Sorry for the trouble. This should be fixed on master again with 85ab7a7.

@asodja
Copy link
Author

asodja commented Apr 3, 2019

No problem. I appreciate great work you are doing. Renv works really great for me.

Keep up the good work!

@kevinushey
Copy link
Collaborator

I'm very glad to hear it :-) Please let us know if you run into any issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants