Fix #1824: HEAD request on static files causes app to stop #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that for HEAD requests specifically, we implement an explicit Content-Length header (normally we let httpuv figure out the Content-Length based on the content, but for HEAD we don't return any content but still want to include the Content-Length). The Content-Length header was only implemented correctly for string values, not for raw vectors or file-by-path. This change implements the value correctly for all currently valid httpuv content.
|
@wch, I didn't include code to only unlink if in a temp dir. It's clear from the |
wch
reviewed
Aug 23, 2017
| NULL | ||
| } | ||
|
|
||
| if (is.na(result)) { |
There was a problem hiding this comment.
When would the result be NA? The cases I can think of are an NA string input, and when file.info() is called on a file that doesn't exist. A comment about this would be helpful so we remember.
wch
reviewed
Aug 23, 2017
R/middleware.R
Outdated
| getResponseContentLength <- function(response, deleteOwnedContent) { | ||
| force(deleteOwnedContent) | ||
|
|
||
| result <- if (is.character(response$content)) { |
There was a problem hiding this comment.
It looks like you're trying to be strict about checking the input, and so it might be good to check that the length is 1.
|
Other than a couple small comments, it looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that for HEAD requests specifically, we implement
an explicit Content-Length header (normally we let httpuv figure
out the Content-Length based on the content, but for HEAD we don't
return any content but still want to include the Content-Length).
The Content-Length header was only implemented correctly for string
values, not for raw vectors or file-by-path. This change implements
the value correctly for all currently valid httpuv content.