Fix labels with bindEvent() #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
reviewed
Nov 23, 2020
Comment on lines
+255
to
+256
| if (x$.execCount > 0) { | ||
| stop("Cannot call bindEvent() on an Observer that has already been executed.") |
|
/document |
|
runner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
schloerke
approved these changes
Nov 23, 2020
This was referenced Dec 4, 2020
|
Expected reactlog after the changes from #3206
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for rstudio/shinycoreci-apps#83.
The reactive graph now looks like this:
Note that the new
private$currentThemeDependencynode was introduced by #3116, and is expected.This also changes the behavior of
observe() %>% bindEvent()so that the original observer is modified in place.