Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Monkey testing with {shinytest2} #140

Merged
merged 17 commits into from
Mar 29, 2022
Merged

DOC: Monkey testing with {shinytest2} #140

merged 17 commits into from
Mar 29, 2022

Conversation

DivadNojnarg
Copy link
Contributor

@schloerke : I just started the vignette. You'll be able to see the progress here.

@schloerke
Copy link
Collaborator

Thank you!

@schloerke schloerke added this to the v0.0.1 milestone Mar 17, 2022
@schloerke schloerke added the documentation Improvements or additions to documentation label Mar 18, 2022
@DivadNojnarg
Copy link
Contributor Author

@schloerke : Do the latest API changes require to update the vignette? Thinking about run_js vs execute_js

schloerke
schloerke reviewed Mar 18, 2022
View reviewed changes
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes to use $get_js() or $run_js()

vignettes/monkey-testing.Rmd Outdated Show resolved Hide resolved
vignettes/monkey-testing.Rmd Outdated Show resolved Hide resolved
vignettes/monkey-testing.Rmd Outdated Show resolved Hide resolved
vignettes/monkey-testing.Rmd Outdated Show resolved Hide resolved
vignettes/monkey-testing.Rmd Outdated Show resolved Hide resolved
schloerke and others added 7 commits March 18, 2022 16:32
@schloerke
Merge branch 'main' into doc-headless-testing
821ef17
@DivadNojnarg @schloerke
import latest API changes (run_js)
a618b34 
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@DivadNojnarg @schloerke
import latest API changes (get_js)
6727b34 
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@DivadNojnarg @schloerke
import latest API changes (run_js/get_js)
27634b0 
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@DivadNojnarg @schloerke
import latest API changes (run_js)
07bff74 
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@DivadNojnarg @schloerke
import latest API changes (run_js)
3cb7b97 
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@DivadNojnarg
replace get_log by get_logs
2fe070a
@DivadNojnarg DivadNojnarg marked this pull request as ready for review March 22, 2022 07:39
schloerke
schloerke reviewed Mar 29, 2022
View reviewed changes
vignettes/monkey-testing.Rmd Outdated Show resolved Hide resolved
vignettes/monkey-testing.Rmd Outdated Show resolved Hide resolved
vignettes/monkey-testing.Rmd Outdated Show resolved Hide resolved
@schloerke
Copy link
Collaborator

Thank you so much @DivadNojnarg !

@schloerke schloerke enabled auto-merge (squash) March 29, 2022 16:52
@schloerke schloerke merged commit 248da4a into rstudio:main Mar 29, 2022
@schloerke schloerke mentioned this pull request Mar 30, 2022
Closed
schloerke added a commit that referenced this pull request Mar 30, 2022
@schloerke
Merge branch 'main' into robust_testing
c90dbf8 
* main:
  DOC: Monkey testing with {shinytest2} (#140)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DivadNojnarg @schloerke