Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make references generated by Pandoc >= 2.7 work in the margin #64

Merged
merged 3 commits into from
May 11, 2019

Conversation

dfeng
Copy link
Contributor

@dfeng dfeng commented May 4, 2019

In the new version of pandoc, the format has been changed from
<a href="#ref-?"> to <a href="#ref-?" role="doc-biblioref"> (a la jgm/pandoc#4213).

This fixes the regex to allow for both versions.

dfeng added 2 commits May 4, 2019 18:52
<a href=""> to <a href="" role="doc-biblioref">

ala jgm/pandoc#4213
backward compatibility
@dfeng dfeng changed the title Patch 1 Fix for new pandoc format May 4, 2019
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@yihui yihui added this to the v0.5 milestone May 11, 2019
@yihui yihui changed the title Fix for new pandoc format Make references generated by Pandoc >= 2.7 work in the margin May 11, 2019
@yihui yihui merged commit e133cc2 into rstudio:master May 11, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants