-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify hyrolo match count #500
Conversation
The HyRolo count values are how many records matched the search pattern, not how many matches exist within the records, i.e. records can have more than one match to the pattern. So the correct value in your test is 2. That is what you should get. |
Aha. I see. A third option on how it should be interpreted. 😄 That is good news. Just a misunderstanding on my part then. I'll update the test case and see what more tests I can construct. What do you think of making the docs clearer on this part so even I can understand? 😆 |
ebad0d7
to
07891ea
Compare
The tests are now updated and I have added some more verification. Count entries with only headerline match, count entries with no headerline match and no match at all. I can't get the numbers to line up so the test case is still marked as an expected failure. Can it be further misunderstand on my part of what different values on the parameters MAX-MATCHES and HEADLINE-ONLY really means? |
Well, I did clarify the docs with my pushes last night. We can have a look today.-- BobOn Mar 31, 2024, at 6:29 AM, Mats Lidell ***@***.***> wrote:
@rswgnu
I'll update the test case and see what more tests I can construct.
The tests are now updated and I have added some more verification. Count entries with only headerline match, count entries with no headerline match and no match at all. I can't get the numbers to line up so the test case is still marked as an expected failure.
Can it be further misunderstand on my part of what different values on the parameters MAX-MATCHES and HEADLINE-ONLY really means?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
😄 That is like hitting a running target. To hard for me! |
07891ea
to
37e6150
Compare
What
Verify hyrolo match count.
Why
Hyrolo match regexps under different options. This is a start
verifying the count result using either match all or just match
headlines. Both types of matches looks like they fail.
The first search for all matches returns 2 but in HyRolo all
three lines containing "match" are highlighted. The second
search for just searching in headlines does not find any match.
Sharing for information. I tried to debug this today but with no
success.
Marked as expected to fail for not breaking the CI.
Note
Can I have I misunderstood what headline means in this
context? I'm assuming that in org mode it is the first line
/following a star.