Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Invoker class with using queue #71

Closed
1 task done
rszamszur opened this issue Apr 13, 2022 · 0 comments · Fixed by #70
Closed
1 task done

Refactor Invoker class with using queue #71

rszamszur opened this issue Apr 13, 2022 · 0 comments · Fixed by #70
Assignees
Labels
refactor Related to major code refactoring/reorganisation
Milestone

Comments

@rszamszur
Copy link
Member

rszamszur commented Apr 13, 2022

  • I have searched the issues of this repo and believe that this is not a duplicate.

Feature Request

There is no need for a fixed amount of Invoker commands to execute (on_start, on_finish). A better solution would be a queue which would store and execute commands.

Implementation wise use collections.deque because of the constant time O(1) for poping and appending elements at both ends of the list (https://wiki.python.org/moin/TimeComplexity).

Related to: #51

@rszamszur rszamszur added the refactor Related to major code refactoring/reorganisation label Apr 13, 2022
@rszamszur rszamszur self-assigned this Apr 13, 2022
@rszamszur rszamszur added this to the 0.11.0 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Related to major code refactoring/reorganisation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant