-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crane_x7_descriptionをリポジトリから削除し、インストール手順を更新する。 #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShotaAk
added
Type: Breaking Change
Includes breaking changes
Type: Maintenance
Repository Maintenance
labels
May 26, 2022
Tiryoh
reviewed
May 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
catkin clean
を使わない場合に特定のパッケージのみ再ビルドするのは難しいですね。
catkin_ws以下の他のパッケージをも含めてすべて再ビルドすることは記載したほうが親切だと思います。
Co-authored-by: Daisuke Sato <daisuke.sato@rt-net.jp>
Co-authored-by: Daisuke Sato <daisuke.sato@rt-net.jp>
Co-authored-by: Daisuke Sato <daisuke.sato@rt-net.jp>
Tiryoh
approved these changes
May 26, 2022
パッケージ移行前のcrane_x7_descriptionの変更ログは以下から確認できます https://github.com/rt-net/crane_x7_ros/commits/v1.0.0/crane_x7_description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
#154 の作業です。
crane_x7_descriptionリポジトリを削除し、インストール手順を更新します。
Does this close any currently open issues?
いいえ
How has this been tested?
新しい手順でパッケージをビルドした後、
roslaunch crane_x7_bringup demo.launch
を実行し、CRANE-X7のモデルが表示されることを確認しました。Any other comments?
ライセンスの変更、バージョンタグの更新については別PRで実施します。
Checklists