Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crane_x7_descriptionをリポジトリから削除し、インストール手順を更新する。 #155

Merged
merged 9 commits into from
May 26, 2022

Conversation

ShotaAk
Copy link
Contributor

@ShotaAk ShotaAk commented May 26, 2022

What does this implement/fix?

#154 の作業です。
crane_x7_descriptionリポジトリを削除し、インストール手順を更新します。

Does this close any currently open issues?

いいえ

How has this been tested?

新しい手順でパッケージをビルドした後、roslaunch crane_x7_bringup demo.launchを実行し、CRANE-X7のモデルが表示されることを確認しました。

Any other comments?

ライセンスの変更、バージョンタグの更新については別PRで実施します。

Checklists

@ShotaAk ShotaAk added Type: Breaking Change Includes breaking changes Type: Maintenance Repository Maintenance labels May 26, 2022
@ShotaAk ShotaAk requested a review from Tiryoh May 26, 2022 08:30
Copy link
Contributor

@Tiryoh Tiryoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catkin cleanを使わない場合に特定のパッケージのみ再ビルドするのは難しいですね。
catkin_ws以下の他のパッケージをも含めてすべて再ビルドすることは記載したほうが親切だと思います。

README.md Show resolved Hide resolved
README.en.md Show resolved Hide resolved
README.en.md Outdated Show resolved Hide resolved
Shota Aoki and others added 3 commits May 26, 2022 18:12
Co-authored-by: Daisuke Sato <daisuke.sato@rt-net.jp>
Co-authored-by: Daisuke Sato <daisuke.sato@rt-net.jp>
Co-authored-by: Daisuke Sato <daisuke.sato@rt-net.jp>
@Tiryoh
Copy link
Contributor

Tiryoh commented May 26, 2022

パッケージ移行前のcrane_x7_descriptionの変更ログは以下から確認できます

https://github.com/rt-net/crane_x7_ros/commits/v1.0.0/crane_x7_description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Change Includes breaking changes Type: Maintenance Repository Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants