-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type-safe persistStore() #1085
base: master
Are you sure you want to change the base?
type-safe persistStore() #1085
Conversation
Someone knows what happen with the PR's in this repo? |
Kindly merge this Branch. This PR can solve type error related to store. |
Hey guys, when are u merging this? |
up |
I think ive solved it just adding "PersistPartial" type in the createStore function: |
Hi there, this looks like a decent solution to me! Thank you very much, just patched it in my project 🙏 |
This looks like it could fix my problem. Is this gonna get merged? |
Hello, any update for this PR? Seems like a solution for type error issue related to store. |
Hello ! I patched it into my project and it works :) Could you merge it? |
@rt2zz Is it possible to merge this in please? |
@sunnylqm Is there any reason it cannot be merged yet? |
Why cannot be merge??? |
I do not have the permission. I made an approval to try to remind those who have permissions to merge. (Yes, anyone can approve) |
@rt2zz why cannot be merge? |
can we merge? :) |
@rt2zz please merge, I need this as well 🙏 |
any update on when it will be merged? |
Is there any news on the merge of this PR, would be very much appreciated. |
waiting over a year for this to get merged, this is kind of ridiculous |
It's still not merged? |
Kindly merge this and include it in a new release as soon as possible. |
@arzyu :) |
I don’t have permission to merge code, hope the maintainer will continue to be active. |
I love it! |
please merge this |
has conflicts @arzyu are you able to resolve? |
After this patch, we can
persistStore(store)
without any type errors when usingstore: Store<RootState, RootAction>
.Here is my usage scenario: