Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo user preference #36

Merged
merged 9 commits into from
Feb 5, 2024
Merged

Demo user preference #36

merged 9 commits into from
Feb 5, 2024

Conversation

fellyph
Copy link
Contributor

@fellyph fellyph commented Feb 1, 2024

Hi @gagan0123, This pull request is on draft; I have a few items that I want to check:

  • I will include status messages on the preference page, same as the analytics page
  • I'm loading the preferences on domain C; when the page is fetching, I have a tiny blink between dark and light mode. Can I add a loader for it?
  • Some JavaScript files are using (function(){}()), and some are using DOMContentLoaded. Should we define a standard to load and execute JavaScript?

Homepage
home page

Light Mode
light mode

Dark Mode
dark mode

@fellyph fellyph changed the title Feature/demo user preference Demo user preference Feb 1, 2024
@fellyph fellyph marked this pull request as draft February 1, 2024 20:36
@gagan0123
Copy link
Member

  • I will include status messages on the preference page, same as the analytics page

How will that status message look like?

  • I'm loading the preferences on domain C; when the page is fetching, I have a tiny blink between dark and light mode. Can I add a loader for it?

Loader will work, but keep it simple, as soon as the iframe is loaded, remove that loader. We can also add dns-prefetch for the iframe domain in the parent, so that at least the DNS query does not take long.

  • Some JavaScript files are using (function(){}()), and some are using DOMContentLoaded. Should we define a standard to load and execute JavaScript?

We can keep that for later, as having the demo ready has more priority than refactoring the code.

@fellyph fellyph added the Demo Demos to display the PSAT functionalities label Feb 5, 2024
@fellyph fellyph marked this pull request as ready for review February 5, 2024 15:06
@fellyph fellyph merged commit 141c34b into develop Feb 5, 2024
1 check passed
@fellyph fellyph deleted the feature/demo-user-preference branch February 5, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Demo Demos to display the PSAT functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants