Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use release versions as dev-net docker image versions #32

Merged
merged 8 commits into from
Apr 17, 2020
Merged

Use release versions as dev-net docker image versions #32

merged 8 commits into from
Apr 17, 2020

Conversation

pangduckwai
Copy link
Collaborator

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

@pangduckwai pangduckwai merged commit 7d32b6f into master Apr 17, 2020
@pangduckwai pangduckwai deleted the dnimgver2 branch April 17, 2020 08:11
@rtang03 rtang03 added the enhancement New feature or request label Apr 17, 2020
@rtang03 rtang03 added this to the sprint-3 milestone Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pangduckwai pangduckwai

Labels
enhancement New feature or request
Projects
None yet
Milestone
sprint-3
Development

Successfully merging this pull request may close these issues.
2 participants
@pangduckwai @rtang03