Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encourage merging of session-level attributes? #19

Closed
ekr opened this issue May 12, 2014 · 2 comments
Closed

Encourage merging of session-level attributes? #19

ekr opened this issue May 12, 2014 · 2 comments
Labels
editor-ready

Comments

@ekr
Copy link
Contributor

ekr commented May 12, 2014

S 5.2.1 says:

Attributes that are common between all m= sections MAY be moved to
session-level, if explicitly defined to be valid at session-level.

This seems like it would be better as a should
@ekr ekr added the m-lines label May 12, 2014
@martinthomson
Copy link
Contributor

Discussed in DC: Some concerns that things that appear at the session level have, in the past, missed by bad implementations.

@fluffy
Copy link
Contributor

fluffy commented May 20, 2014

Dc - decdie to change to SHOULD NOT and for things that are big, like idientiy, will put MUST

@ekr ekr added the PR Pending label May 22, 2014
@ekr ekr closed this as completed in e359f3c May 29, 2014
ekr added a commit that referenced this issue May 29, 2014
@ekr
Merge pull request #38 from ekr/session_level_attributes_issue19
946ee8e 
Guidance on where attributes should be. fixes #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editor-ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martinthomson @fluffy @ekr