Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer without m-section allowed #832

Closed
nils-ohlmeier opened this issue Aug 30, 2017 · 2 comments
Closed

Offer without m-section allowed #832

nils-ohlmeier opened this issue Aug 30, 2017 · 2 comments
Assignees
Labels

Comments

@nils-ohlmeier
Copy link

I failed to find any text in webrtc-pc or JSEP which indicates that the createOffer() call should fail if no RtpTransceiver or data channel has been added to a PeerConnection.

Webrtc-pc contains the following:

  1. If this inspection failed for any reason, reject p with a newly created OperationError and abort these steps.

But section 5.2.1. Initial Offers does not seem to contain any wording indicating to treat the absence of any RtpTransceiver and DataChannel as such an failure.

I think such a scenario should be treated as a failure, as I fail to see any value in generating an empty offer.

@juberti
Copy link
Contributor

juberti commented Aug 31, 2017

Good observation. Personally, I'm inclined to allow this, unless it's forbidden by 3264 - we would just generate the session-level values with no m= sections.

@juberti
Copy link
Contributor

juberti commented Aug 31, 2017

3264 indicates that this is OK:

 The offer will contain zero or more media streams (each media stream
 is described by an "m=" line and its associated attributes).  Zero
 media streams implies that the offerer wishes to communicate, but
 that the streams for the session will be added at a later time
 through a modified offer.

I think we should explicitly mention that this is allowed, but otherwise take no action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants