Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A configuration file was not found (after 2.6.6 update) #4668

Closed
nikolay-bushkov opened this issue Sep 27, 2018 · 16 comments
Closed

A configuration file was not found (after 2.6.6 update) #4668

nikolay-bushkov opened this issue Sep 27, 2018 · 16 comments
Labels
Support Support question

Comments

@nikolay-bushkov
Copy link

Details

Expected Result

Successful build.

Actual Result

Build failed even in the branch that was not updated. It seems that update to 2.6.6 break it. Any ideas how to fix it?

@RichardLitt RichardLitt added the Support Support question label Sep 27, 2018
@sobolevn
Copy link

sobolevn commented Sep 27, 2018

I have also seen this error for several of my projects.

I have also tried to specify config file manually in "Advanced settings", but it did not work.
I hope to see a patch soon! 🙏

@stsewd
Copy link
Member

stsewd commented Sep 27, 2018

I'm going to look at this now

@williamfgc
Copy link

I have the same problem since this morning: https://readthedocs.org/projects/adios2-adaptable-io-system-version-2/builds/7852603/

@stsewd
Copy link
Member

stsewd commented Sep 27, 2018

Ok, I found the problem (with @nikolay-bushkov's project at least). What happens if that you have a .readthedocs.yml file inside your docs dir instead of the root of your project (as the docs recommend https://docs.readthedocs.io/en/latest/yaml-config.html). This was working in the past because we try to find a rtd config in the whole project internally, and we didn't use this value to get the absolute path of the conf.py file, but we are changing some stuff to bring a v2 of the config file, and now we are using that value.

Not sure if we want to allow that (.readthedos.yml file inside a dir). So, I going to ask the to team if this should be treated like a bug or something else.

@stsewd
Copy link
Member

stsewd commented Sep 27, 2018

@sobolevn can you share your rtd project? Or see if your case is the same as above ^

@stsewd
Copy link
Member

stsewd commented Sep 27, 2018

@williamfgc your case is the same as above https://github.com/ornladios/ADIOS2/blob/master/thirdparty/pybind11/pybind11/.readthedocs.yml

@stsewd
Copy link
Member

stsewd commented Sep 27, 2018

You can solve this by moving your readthedocs.yml file at the root of your project.

@stsewd stsewd added the Needed: design decision A core team decision is required label Sep 27, 2018
@williamfgc
Copy link

@stsewd Thanks for your help! I thought the build was restricted to ./docs/ that yml file is under thridparty. Can I set up a filter?

@stsewd
Copy link
Member

stsewd commented Sep 27, 2018

RTD have access to the whole repo, as some projects require to run the project to extract docstrings. You should put your rtd config file in the root of the project. If you mean having that file there but ignoring it, currently it's not possible. You should rename that file.

@williamfgc
Copy link

@stsewd yeah, I looked into the docs and I couldn't find anything related. IT could be a useful feature. For example, if we have two projects (user_guide, developers_guide) under the same repo, or like in my case if we depend on thirdparty that must not be modified? Since those are common scenarios, what's the best practice?

@stsewd
Copy link
Member

stsewd commented Sep 27, 2018

So, we decide that we don't want to support this behaviour (and looks like it doesn't match our docs anyway). So, if moving the config file to the project's root solve this, we can close this issue, I'll open a new one to track the deletion of the logic that finds config files inside other directories.

@stsewd
Copy link
Member

stsewd commented Sep 27, 2018

IT could be a useful feature. For example, if we have two projects (user_guide, developers_guide) under the same repo

I think there are some ideas about having multiple configurations, but I don't think we are going to support that. As we will need to need to find a way to choose which project to run. This is the more close thing that we are going to support #4354 (comment). Also, I think rtd is designed for one documentation per repo.

@stsewd
Copy link
Member

stsewd commented Sep 27, 2018

like in my case if we depend on thirdparty that must not be modified?

We are going to remove the finding logic, so that should fix that case.

@williamfgc
Copy link

@stsewd great! Thanks! Keep up with the great work in rtd!

@stsewd
Copy link
Member

stsewd commented Sep 29, 2018

Just in case, a workaround is creating your own .readthedocs.yml file in the root of your project.

@williamfgc
Copy link

@stsewd adding .readthedocs.yml solved our issue. Thanks!

gasman added a commit to wagtail/wagtail that referenced this issue Oct 11, 2018
gasman added a commit to wagtail/wagtail that referenced this issue Oct 11, 2018
cxw42 added a commit to cxw42/editorconfig-specification that referenced this issue Nov 11, 2023
cxw42 added a commit to cxw42/editorconfig-specification that referenced this issue Nov 11, 2023
blester125 added a commit to blester125/word-vectors that referenced this issue Jan 13, 2024
cxw42 added a commit to editorconfig/specification that referenced this issue Feb 2, 2024
* Add spelling_language property

To specify the natural language for which spelling should be checked.

* Add .readthedocs.yaml

Now required per
readthedocs/readthedocs.org#4668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support Support question
Projects
None yet
Development

No branches or pull requests

5 participants