Upgrade django-pagination to a "maintained" fork #3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #3664 The package `django-pagination` got unmaintained, so a fork by Linaro was created at https://github.com/zyga/django-pagination and got unmaintained again (zyga/django-pagination#42). Now, there is another fork at https://github.com/pydanny/dj-pagination) that contains more compatibility releases. So, I'm upgrading to this one.
This was referenced Feb 23, 2018
|
What method of testing was used here to confirm it doesn't break on the actual site? |
RichardLitt
added
PR: work in progress
…/django-pagination/upgrade
|
@ericholscher all the test are passing without problem and I also tested this manually by hitting all the pages where
I wasn't able to test it in (I don't have elasticsearch configured)
Let me know if you consider that it's enough. |
humitos
added
PR: ready for review
and removed
Needed: more information
|
That should be fine. I just wanted to make sure it was tested in a running instance, and not just the unit tests. |
ericholscher
approved these changes
Mar 6, 2018
|
@ericholscher can we merge this one? |
|
👍 -- let's wait til tomorrow, but then merge~! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3664
The package
django-paginationgot unmaintained, so a fork by Linarowas created at https://github.com/zyga/django-pagination and got
unmaintained again (zyga/django-pagination#42).
Now, there is another fork at https://github.com/pydanny/dj-pagination)
that contains more compatibility releases. So, I'm upgrading to this one.