Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start building with sphinx 1.8 #5366

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Feb 27, 2019

Currently we use sphinx 1.7,
we already have some projects building with 1.8 (with feature flag)
and with custom requirements.

We also have fixed/adapted some of our code to support the
new version.

I'm also updating the projects with a feature flag to use 2.0
when it's available.

Release history https://pypi.org/project/Sphinx/#history

Currently we use sphinx 1.7,
we already have some projects building with 1.8 (with feature flag)
and with custom requirements.

We also have fixed/adapted some of our code to support the
new version.

I'm also updating the projects with a feature flag to use 2.0
when it's available.
@stsewd stsewd requested a review from a team February 27, 2019 19:13
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a breaking change to me.

Once 2.0 gets released, projects with USE_LATEST_SPHINX will probably fail on building if they don't have Sphinx pinned to a specific version.

Why not to use <1.9 and <2.0 instead for now and once 2.0 is released and more tested we make the change proposed in the PR?

@stsewd
Copy link
Member Author

stsewd commented Feb 27, 2019

There isn't going to be a 1.9 release, but, yeah, we can just put the same version for both

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. We should also look at upgrading our other python_environments requirements in this PR. The pillow and other packages we install are quite old.

@stsewd
Copy link
Member Author

stsewd commented Mar 4, 2019

Makes sense. We should also look at upgrading our other python_environments requirements in this PR. The pillow and other packages we install are quite old.

I'll open a new PR with those requirements. I want so see how they affect us first :)

@stsewd stsewd merged commit c428dd3 into readthedocs:master Mar 4, 2019
@stsewd stsewd deleted the start-building-with-sphinx-18 branch March 4, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants