Start building with sphinx 1.8 #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use sphinx 1.7, we already have some projects building with 1.8 (with feature flag) and with custom requirements. We also have fixed/adapted some of our code to support the new version. I'm also updating the projects with a feature flag to use 2.0 when it's available.
humitos
reviewed
Feb 27, 2019
There was a problem hiding this comment.
This sounds like a breaking change to me.
Once 2.0 gets released, projects with USE_LATEST_SPHINX will probably fail on building if they don't have Sphinx pinned to a specific version.
Why not to use <1.9 and <2.0 instead for now and once 2.0 is released and more tested we make the change proposed in the PR?
|
There isn't going to be a 1.9 release, but, yeah, we can just put the same version for both |
ericholscher
approved these changes
Mar 1, 2019
davidfischer
approved these changes
Mar 1, 2019
I'll open a new PR with those requirements. I want so see how they affect us first :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use sphinx 1.7,
we already have some projects building with 1.8 (with feature flag)
and with custom requirements.
We also have fixed/adapted some of our code to support the
new version.
I'm also updating the projects with a feature flag to use 2.0
when it's available.
Release history https://pypi.org/project/Sphinx/#history