New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the sidebar ad color #5731

Merged

davidfischer merged 1 commit into master from davidfischer/sidebar-ad-color-fix

May 30, 2019

Contributor

davidfischer commented May 24, 2019

Using transparency was a mistake especially when the sidebar color can be changed
This color is 10% lighter than the default background color on the RTD theme which is what the transparency attempted to accomplish.
Fixes: Banners don't render nicely depending on Project CSS #5563


          Fix the sidebar ad color

9f536e4

- Using transparency was a mistake
  especially when the sidebar color can be changed

davidfischer requested a review from a team

May 24, 2019 20:50

humitos approved these changes

View reviewed changes

davidfischer merged commit ae14393 into master

delete-merged-branch bot deleted the davidfischer/sidebar-ad-color-fix branch

May 30, 2019 17:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet