Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instanceof checks can cause issues #61

Closed
WickyNilliams opened this issue Sep 23, 2015 · 1 comment
Closed

instanceof checks can cause issues #61

WickyNilliams opened this issue Sep 23, 2015 · 1 comment

Comments

@WickyNilliams
Copy link

Using instanceof to check for arrays etc. can cause issues across frame boundaries. Each document has a different context so one array may not be an instanceof another.

var frame = document.createElement("iframe");

frame.onload = function(e) {
  console.log([] instanceof frame.contentWindow.Array); // false
}

document.body.appendChild(frame);
@rtfeldman
Copy link
Owner

Hm, I don't quite follow the case where this could cause a problem for seamless-immutable.

Could you show a code example where this would lead seamless-immutable to behave undesirably?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants