template: Conditionally hide diffs with many lines #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added maxLinesShowing to configuration, which can be used to collapse files that exceed that number of changed lines. Also adds collapse/expand feature to files in all cases
rtfpessoa
requested changes
Feb 5, 2019
There was a problem hiding this comment.
I had a quick look and this feature looks nice.
Thanks for your contribution.
The only thing that seems weird is the fact that we are dealing with the decision during the parse.
Can we keep the parser unchanged and just perform the size check during the UI generation?
|
@lynques any plans to review this? |
|
Closing for inactivity. Let me know if you want to look at this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to this issue in the diff2html-cli repo rtfpessoa/diff2html-cli#36, and will have a corresponding PR in that project shortly to add the command line flag for cli usage.