_WireReader.read() should make flags a dns.flags.Flag [Issue #606]

rthalley · Jan 4, 2021 · 14bbb9c · 14bbb9c
1 parent 00b5754
commit 14bbb9c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/dns/message.py b/dns/message.py
@@ -990,7 +990,7 @@ def read(self):
             self.parser.get_struct('!HHHHHH')
         factory = _message_factory_from_opcode(dns.opcode.from_flags(flags))
         self.message = factory(id=id)
-        self.message.flags = flags
+        self.message.flags = dns.flags.Flag(flags)
         self.initialize_message(self.message)
         self.one_rr_per_rrset = \
             self.message._get_one_rr_per_rrset(self.one_rr_per_rrset)

diff --git a/tests/test_message.py b/tests/test_message.py
@@ -676,6 +676,11 @@ def test_bad_text_rrs(self):
             IN SOA
 ''')
 
+    def test_from_wire_makes_Flag(self):
+        m = dns.message.from_wire(goodwire)
+        self.assertIsInstance(m.flags, dns.flags.Flag)
+        self.assertEqual(m.flags, dns.flags.Flag.RD)
+
 
 if __name__ == '__main__':
     unittest.main()