Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOC records are parsed incorrectly #47

Closed
spacekpe opened this issue Jan 21, 2014 · 1 comment
Closed

LOC records are parsed incorrectly #47

spacekpe opened this issue Jan 21, 2014 · 1 comment

Comments

@spacekpe
Copy link

Hello!

I have found that LOC records have incorrect default values for size, horizontal and vertical precision. Also the explicit value for vertical precision is not parsed correctly if there is no 'm' (unit) at the end of input.

I have patches for both problems so I will create pull request. The third patch adds unit tests for LOC records so you can try it yourself that it really doesn't work with current master :-)

Have a nice day!

rthalley added a commit that referenced this issue Jan 22, 2014
Fix issue #47 - LOC record parsing
encukou pushed a commit to freeipa/freeipa that referenced this issue Feb 18, 2014
Older versions of dnspython have problems with implicit values for
size and h/v precision so our tests use explicit value.
See rthalley/dnspython#47

This change is necessary because we want to test if data visible
over DNS protocol matches data visible over LDAP.
encukou pushed a commit to freeipa/freeipa that referenced this issue Feb 21, 2014
Older versions of dnspython have problems with implicit values for
size and h/v precision so our tests use explicit value.
See rthalley/dnspython#47

This change is necessary because we want to test if data visible
over DNS protocol matches data visible over LDAP.

Reviewed-By: Petr Viktorin <pviktori@redhat.com>
@rthalley
Copy link
Owner

This was fixed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants