Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roff: dots are not escaped correctly at beginning of line #46

Open
sometimesfood opened this issue Dec 8, 2010 · 4 comments
Open

roff: dots are not escaped correctly at beginning of line #46

sometimesfood opened this issue Dec 8, 2010 · 4 comments

Comments

@sometimesfood
Copy link
Contributor

While dots at the beginning of a line are escaped correctly, the check in the write method does not catch all cases where there are spaces in front of the dot in a NF:

$ man --warnings test/markdown_syntax.roff > /dev/null
<standard input>:1450: warning: macro `dot' not defined
    (possibly missing space after `do')
$ groff -T ascii test/markdown_syntax.roff 2>/dev/null | grep dot
$
@sometimesfood
Copy link
Contributor Author

Here's a testcase:

@sometimesfood
Copy link
Contributor Author

Here's a fix:
#48

@thinkerbot
Copy link

See #65. That may also fix this issue.

sometimesfood added a commit to sometimesfood/ronn that referenced this issue Aug 2, 2014
@sometimesfood
Add test case for issue rtomayko#46
df0d9a6
sometimesfood added a commit to sometimesfood/ronn that referenced this issue Aug 2, 2014
@sometimesfood
Fix rtomayko#44: Clean up unnecessary dot escaping in roff
39db941 
 - Move the escaping for dots at the beginning of a line from the line
   level (write) to the node level (escape). (That's why some
   unnecessary escapes remain unchanged.)

 - This also fixes rtomayko#46 ("roff: dots are not escaped correctly at
   beginning of line").
@sometimesfood sometimesfood mentioned this issue Dec 8, 2010
Open
@apjanke apjanke mentioned this issue Dec 25, 2018
Closed
@apjanke
Copy link

apjanke commented Dec 25, 2018

If you're still interested, I've fixed this case in my Ronn-NG fork at apjanke/ronn-ng#17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thinkerbot @sometimesfood @apjanke