Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary dot escaping in roff? #44

Open
sometimesfood opened this issue Dec 1, 2010 · 0 comments · May be fixed by #48
Open

Unnecessary dot escaping in roff? #44

sometimesfood opened this issue Dec 1, 2010 · 0 comments · May be fixed by #48

Comments

@sometimesfood
Copy link
Contributor

Are you sure you have to escape all dots in roff? I'm not a roff expert by any stretch of the imagination but as far as I can tell this shouldn't be necessary.

See "gzcat /usr/share/man/man7/roff.7.gz | less" for reference.

The dot escaping was introduced in 6a410d9 and looks like it should have been a fix for #21.

But since you have to check for dots at the beginning of a line anyway – which you do since 11cbb86 – you should be ok without the dot escaping.

Am I missing something or do you want me to send you a patch?
sometimesfood added a commit to sometimesfood/ronn that referenced this issue Aug 2, 2014
@sometimesfood
Fix rtomayko#44: Clean up unnecessary dot escaping in roff
39db941 
 - Move the escaping for dots at the beginning of a line from the line
   level (write) to the node level (escape). (That's why some
   unnecessary escapes remain unchanged.)

 - This also fixes rtomayko#46 ("roff: dots are not escaped correctly at
   beginning of line").
@sometimesfood sometimesfood linked a pull request Dec 8, 2010 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@sometimesfood