Deprecate BlueCloth, Less, and Sigil support #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of these are tested in CI. BlueCloth conflicts with RDiscount. It could theoretically be tested in CI if RDiscount was in primary templates and BlueCloth in secondary templates, but considering BlueCloth hasn't had a release in over 10 years, and Tilt supports many other markdown formats, there isn't a good reason to keep supporting it. Less on CRuby depends on therubyracer, which no longer works on modern Ruby due to changes in Psych. I tried enabling it in CI, and it won't install (https://github.com/jeremyevans/tilt/runs/7812514562?check_suite_focus=true#step:4:155). Less hasn't had a release in over 8 years, and therubyracer hasn't had a release in over 5 years. Sigil doesn't have a gem, and isn't even packaged for my operating system (OpenBSD). It's possible we could test it in CI if it is packaged for whatever Linux distro CI uses, but I doubt the usage of tilt/sigil is high enough to justify that. If any tilt user really needs these template engines, they can just copy the related template file and require it manually.
gma
added a commit
to gma/nesta
that referenced
this pull request
Jul 11, 2023
BlueCloth has been removed in Tilt 2.2.0, as it conflicts with RDiscount and hasn't been updated in 10 years. See rtomayko/tilt#382 for details.
gma
added a commit
to gma/nestacms.com
that referenced
this pull request
Apr 12, 2024
BlueCloth has been deprecated in Tilt, so it no longer makes sense to use it in example code that configures Nesta's Markdown processor. See rtomayko/tilt#382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these are tested in CI.
BlueCloth conflicts with RDiscount. It could theoretically be
tested in CI if RDiscount was in primary templates and BlueCloth
in secondary templates, but considering BlueCloth hasn't had a
release in over 10 years, and Tilt supports many other markdown
formats, there isn't a good reason to keep supporting it.
Less on CRuby depends on therubyracer, which no longer works on
modern Ruby due to changes in Psych. I tried enabling it in CI,
and it won't install (https://github.com/jeremyevans/tilt/runs/7812514562?check_suite_focus=true#step:4:155).
Less hasn't had a release in over 8 years, and therubyracer hasn't
had a release in over 5 years.
Sigil doesn't have a gem, and isn't even packaged for my operating
system (OpenBSD). It's possible we could test it in CI if it is
packaged for whatever Linux distro CI uses, but I doubt the usage
of tilt/sigil is high enough to justify that.
If any tilt user really needs these template engines, they can just
copy the related template file and require it manually.