Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of extractExtends() #44

Closed
wants to merge 1 commit into from
Closed

Improve performance of extractExtends() #44

wants to merge 1 commit into from

Conversation

scott113341
Copy link
Collaborator

@scott113341 scott113341 commented Jun 12, 2016 •
edited
Loading

We can skip all the work that extractExtends() performs with a trivial check for \sextends\s in the passed CSS string. I don't have numbers, but I believe this will increase performance non-insignificantly 😉
#39

@scott113341
Increased performance of extractExtends() by skipping all extraction …
cb20415 
…work if no extends are present in the CSS string
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cb20415 on scott113341:extract-extends-performance into 484612b on rtsao:master.

@scott113341
Copy link
Collaborator Author

Closing for now, can revisit this later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scott113341 @coveralls