Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linting from nox #46

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Remove linting from nox #46

merged 1 commit into from
Nov 11, 2021

Conversation

adamchainz
Copy link
Contributor

The linters are configured to run with pre-commit too - best to stick to one tool. For CI, pre-commit.ci can be used, or pre-commit run --all-files.

The linters are configured to run with pre-commit too - best to stick to one tool. For CI, pre-commit.ci can be used, or ``pre-commit run --all-files``.
Copy link
Member

@JaapJoris JaapJoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Linting should happen at the source.

@JaapJoris JaapJoris merged commit 4e50e40 into rtts:main Nov 11, 2021
@adamchainz adamchainz deleted the nox_lint branch November 11, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants