Match both https and http for gitorious and github. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Chris - glad you liked the app. I originally didn't include http on github as of course it went https-only a while ago: https://github.com/blog/738-sidejack-prevention-phase-2-ssl-everywhere ...but legacy links still may use the old http protocol, so your patch makes sense - thanks! Commiting now... |
rtyley
added a commit
that referenced
this pull request
Jun 16, 2011
Match both https and http for gitorious and github. I originally didn't include http on github as of course it went https-only a while ago: https://github.com/blog/738-sidejack-prevention-phase-2-ssl-everywhere ...but legacy links still may use the old http protocol, so Chris's patch makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that my link to http://github.com/.../... didn't match, seemingly because Agit is looking for https. Looks like it would have the opposite problem for gitorious? I haven't tested this change at all. :-) Other than that, nice app, thanks.